RFR: JDK-8235541: Extend javax.lang.model to cover binding variables

Joe Darcy joe.darcy at oracle.com
Wed Dec 11 01:33:29 UTC 2019


Hi Jan,

Please fix the try-with-resources typo in the 
TestBindingVariableData.java test:

   42 /**
   43  * Using the tree API, retrieve element representations of the
   44  * resource of a try-with-resources statement and verify their kind
   45  * tags are set appropriately.
   46  */

Otherwise, looks okay; thanks,

-Joe

On 12/10/2019 8:15 AM, Jan Lahoda wrote:
> Hi,
>
> The bindings variables might get their own ElementKind constant (as 
> e.g. resource variables and exception parameters get). The proposed 
> addition is here:
> http://cr.openjdk.java.net/~jlahoda/8235541/webrev.00/
>
> I've started with the CSR here:
> https://bugs.openjdk.java.net/browse/JDK-8235590
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8235541
>
> How does this look?
>
> Thanks,
>      Jan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20191210/9d920f44/attachment.htm>


More information about the compiler-dev mailing list