RFR: JDK-8235541: Extend javax.lang.model to cover binding variables

Jan Lahoda jan.lahoda at oracle.com
Wed Dec 11 23:31:34 UTC 2019


Thanks Joe!

I've changed the comment to:
   42 /**
   43  * Using the tree API, retrieve element representations of the
   44  * binding variables of the type test pattern, and verify their kind
   45  * tags are set appropriately.
   46  */

Full webrev:
http://cr.openjdk.java.net/~jlahoda/8235541/webrev.01/

I'll push this, unless there are objections.

Thanks!

Jan

On 11. 12. 19 2:33, Joe Darcy wrote:
> Hi Jan,
> 
> Please fix the try-with-resources typo in the 
> TestBindingVariableData.java test:
> 
>    42 /**
>    43  * Using the tree API, retrieve element representations of the
>    44  * resource of a try-with-resources statement and verify their kind
>    45  * tags are set appropriately.
>    46  */
> 
> Otherwise, looks okay; thanks,
> 
> -Joe
> 
> On 12/10/2019 8:15 AM, Jan Lahoda wrote:
>> Hi,
>>
>> The bindings variables might get their own ElementKind constant (as 
>> e.g. resource variables and exception parameters get). The proposed 
>> addition is here:
>> http://cr.openjdk.java.net/~jlahoda/8235541/webrev.00/
>>
>> I've started with the CSR here:
>> https://bugs.openjdk.java.net/browse/JDK-8235590
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8235541
>>
>> How does this look?
>>
>> Thanks,
>>      Jan


More information about the compiler-dev mailing list