[PATCH] JDK-8233680: JavacFileManager.close() doesn't clear some cache instance variables

[Daniel Le Duc Khoi Nguyen]

Hi Jon,

I've converted the test to Java and moved it under the javadoc package to avoid
any confusion of it being a compiler test. I've also simplified and add comments
to it. Please refer to JDK-8233680-1.patch.

In order to trigger the bug, one must reuse the JavacFileManager object that is
created automatically by the compiler tools (when no fileManager argument is
passed to getTask) after it's been automatically closed.

This is only possible with JavaDoc and not javac. JavacTaskImpl.cleanup and
JavacTaskImpl.prepareCompiler together make reusing the JavacFileManager object
impossible.

If you'd like to remove JavaDoc from the test dependency, please refer to
JDK-8233680-javac-test-not-working-wip.patch and see if you could take it
further. Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: JDK-8233680-javac-test-not-working-wip.patch
Type: text/x-patch
Size: 4349 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20191220/e6328f69/JDK-8233680-javac-test-not-working-wip.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: JDK-8233680-1.patch
Type: text/x-patch
Size: 4391 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20191220/e6328f69/JDK-8233680-1.patch>