[PATCH] JDK-8233680: JavacFileManager.close() doesn't clear some cache instance variables

[Jonathan Gibbons]

Daniel,

Thank you for the followup. I will take  more detailed look at the 
underlying code
and the use of null arguments for the file manager for JavaCompiler and 
DocumentationTool.

-- Jon

On 12/20/19 1:01 AM, Daniel Le Duc Khoi Nguyen wrote:
> Hi Jon,
>
> I've converted the test to Java and moved it under the javadoc package to avoid
> any confusion of it being a compiler test. I've also simplified and add comments
> to it. Please refer to JDK-8233680-1.patch.
>
> In order to trigger the bug, one must reuse the JavacFileManager object that is
> created automatically by the compiler tools (when no fileManager argument is
> passed to getTask) after it's been automatically closed.
>
> This is only possible with JavaDoc and not javac. JavacTaskImpl.cleanup and
> JavacTaskImpl.prepareCompiler together make reusing the JavacFileManager object
> impossible.
>
> If you'd like to remove JavaDoc from the test dependency, please refer to
> JDK-8233680-javac-test-not-working-wip.patch and see if you could take it
> further. Thank you.