RFR: 8228571: [TESTBUG] Fix tests failing on non-aot platforms after JDK-8227512

[Alan Bateman]

On 24/07/2019 09:08, Langer, Christoph wrote:
>
> Hi,
>
> Please review a fix for two tests that fail on non-aot 
> builds/platforms after JDK-8227512:
>
> langtools/tools/javac/modules/InheritRuntimeEnvironmentTest.java
>
> langtools/tools/javac/file/LimitedImage.java
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8227512 
> <https://bugs.openjdk.java.net/browse/JDK-8227512>
>
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8228571.0/ 
> <http://cr.openjdk.java.net/~clanger/webrevs/8228571.0/>
>
> I would fix it by setting up two test run configurations, one with 
> graal and the other without. Therefore I need to add some 
> configuration to langtools/TEST.ROOT to be able to use “@requires 
> vm.graal.enabled”.
>
>
The update requires.extraPropDefns.bootlibs TEST.ROOT should probably 
include Container.java so that it's consistent with the jdk tests. I 
realize it's unlikely that langtools tests will run docker commands but 
I'm sure the inconsistency will be noticed.

Shouldn't vm.graal.enabled tests include jdk.internal.vm.compiler in the 
@modules list?

I agree with Aleksey about inverting the default for the parameter.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190724/ca18b08e/attachment.html>