RFR: 8228571: [TESTBUG] Fix tests failing on non-aot platforms after JDK-8227512

Aleksey Shipilev shade at redhat.com
Wed Jul 24 08:13:37 UTC 2019


On 7/24/19 10:08 AM, Langer, Christoph wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8227512
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8228571.0/

This inversion is dodgy:

  47  * @run main InheritRuntimeEnvironmentTest graal

...then:

  74         if (args.length > 0) {
  75             hasGraal = false;
  76         }

How about supplying "graal" turn hasGraal=true instead? Maybe even check that first argument is
"graal" indeed.

Otherwise looks okay.

-- 
Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190724/3a4c3351/signature.asc>


More information about the compiler-dev mailing list