RFR: [8218152] javac fails and exits with no error if a bad annotation processor is on the classpath

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon Mar 4 15:41:16 UTC 2019


On 3/1/19 6:00 AM, Steve Groeger wrote:
>
> I did also notice, although you said binary files should not be in the 
> repository, that the existing repository
> has lots of binary files, which seem to be jar files. So is it a 
> definite that binary files are not allowed or only
> in ceratin circumstances. If the latter would it be OK to have the jar 
> files in my webrev in the repo?

Steve,

Binary files in the repo are strongly discouraged, especially in the 
cases where the file is either unnecessary
or can be generated on the fly. We have tools like jasm/jcod that can 
make "strange" class files and we have
API like toolbox that make it easy to make jar files.

Some number of binary files came in when OpenJDK was created, but there 
has been an ongoing background
effort to eliminate these files, although admittedly that work has 
slowed of late.  It would be bad to start
adding new binary files at this point.

-- Jon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190304/bb1bed62/attachment.html>


More information about the compiler-dev mailing list