RFR: [8218152] javac fails and exits with no error if a bad annotation processor is on the classpath

[Steve Groeger]

Hi Jonathan & Jan, 

Thanks for your comments. 
I fully understand the reasoning and will endeavor to make changes that 
removes the 
need for these jar files.  Will post again once I have some new webrevs 
for review.

Thanks
Steve Groeger
IBM Runtime Technologies
Hursley, Winchester
Tel: (44) 1962 816911  Mobex: 279990  Mobile: 07718 517 129
Fax (44) 1962 816800
Lotus Notes: Steve Groeger/UK/IBM
Internet: groeges at uk.ibm.com

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



From:   Jonathan Gibbons <jonathan.gibbons at oracle.com>
To:     compiler-dev at openjdk.java.net
Date:   04/03/2019 15:44
Subject:        Re: RFR: [8218152] javac fails and exits with no error if 
a bad annotation processor is on the classpath
Sent by:        "compiler-dev" <compiler-dev-bounces at openjdk.java.net>




On 3/1/19 6:00 AM, Steve Groeger wrote:

I did also notice, although you said binary files should not be in the 
repository, that the existing repository 
has lots of binary files, which seem to be jar files. So is it a definite 
that binary files are not allowed or only 
in ceratin circumstances. If the latter would it be OK to have the jar 
files in my webrev in the repo?
Steve,
Binary files in the repo are strongly discouraged, especially in the cases 
where the file is either unnecessary
or can be generated on the fly. We have tools like jasm/jcod that can make 
"strange" class files and we have
API like toolbox that make it easy to make jar files.
Some number of binary files came in when OpenJDK was created, but there 
has been an ongoing background
effort to eliminate these files, although admittedly that work has slowed 
of late.  It would be bad to start
adding new binary files at this point.
-- Jon


Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190305/6e4045e4/attachment.html>