RFR: JEP 359-Records: compiler code

Brian Goetz brian.goetz at oracle.com
Tue Oct 22 17:30:51 UTC 2019


Yes, I found these tests to fail when running
    make run-test TEST=“jtreg:/path/to/tests”

It was barfing on “unrecognized source version”, which I took to mean the variable wasn’t being expanded.  

> On Oct 22, 2019, at 1:25 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> Brian,
> 
> What doesn't work with "make run-test"?   Are you saying there's a problem with "--enable-preview -source ${jdk.version}", or with the general methodology of specifying --enable-preview and -source?
> 
> If there's an issue with the jtreg support for ${jdk.version}, I guess I'd like to know.
> 
> -- Jon
> 
> On 10/22/19 9:48 AM, Brian Goetz wrote:
>> This doesn’t work when you invoke the tests through `make run-test`, which is why I used the explicit 14.
>> 
>>> On Oct 22, 2019, at 11:21 AM, Jan Lahoda <jan.lahoda at oracle.com> wrote:
>>> 
>>> -for tests, "--enable-preview -source 14" is used on many places. This will cause issues when JDK 15 is started (and --enable-preview -source 14 will be replaced with --enable-preview -source 15). On all places where that is possible, "--enable-preview -source ${jdk.version}" should be used, or a programmatic equivalent.



More information about the compiler-dev mailing list