RFR: JEP 359-Records: compiler code

[Jonathan Gibbons]

Yes, thanks; I followed up on the JBS issue in Jan's comment. I see that 
the substitution feature is disabled in the jdk repo. I'll work with 
Igor et al to see if we can get the feature enabled there.  For what 
it's worth, it's not specifically related to "make run-test".

-- Jon

On 10/22/19 10:30 AM, Brian Goetz wrote:
> Yes, I found these tests to fail when running
>      make run-test TEST=“jtreg:/path/to/tests”
>
> It was barfing on “unrecognized source version”, which I took to mean the variable wasn’t being expanded.
>
>> On Oct 22, 2019, at 1:25 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
>>
>> Brian,
>>
>> What doesn't work with "make run-test"?   Are you saying there's a problem with "--enable-preview -source ${jdk.version}", or with the general methodology of specifying --enable-preview and -source?
>>
>> If there's an issue with the jtreg support for ${jdk.version}, I guess I'd like to know.
>>
>> -- Jon
>>
>> On 10/22/19 9:48 AM, Brian Goetz wrote:
>>> This doesn’t work when you invoke the tests through `make run-test`, which is why I used the explicit 14.
>>>
>>>> On Oct 22, 2019, at 11:21 AM, Jan Lahoda <jan.lahoda at oracle.com> wrote:
>>>>
>>>> -for tests, "--enable-preview -source 14" is used on many places. This will cause issues when JDK 15 is started (and --enable-preview -source 14 will be replaced with --enable-preview -source 15). On all places where that is possible, "--enable-preview -source ${jdk.version}" should be used, or a programmatic equivalent.