RFR: JDK-8241741 - Implement Text Blocks as a standard feature in javac

Jan Lahoda jan.lahoda at oracle.com
Mon Apr 6 14:41:59 UTC 2020


Hi Jim,

The changes to:
src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java
src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_ja.properties
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties

Probably mean text blocks will be allowed to all source levels (i.e. 
also for --release 14; --release 8; etc.) Is that intentional?

Also, for tests like (but also many others):
test/jdk/java/lang/String/Formatted.java

why keep "@run main/othervm"? Should just "@run main" work as well (but 
faster)?

Jan

On 06. 04. 20 16:33, Jim Laskey wrote:
> Please take the time to review the code changes to make Text Blocks a 
> standard feature for Java. The changes are pretty light-weight and 
> shouldn't take too long to review. Mostly involves removing "preview" 
> trappings.
> 
> Cheers,
> 
> -- Jim
> 
> 
> webrev: http://cr.openjdk.java.net/~jlaskey/8241741/webrev-00
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8241741
> CSR: https://bugs.openjdk.java.net/browse/JDK-8241745
> JEP: https://bugs.openjdk.java.net/browse/JDK-8236934
> 


More information about the compiler-dev mailing list