RFR: JDK-8241741 - Implement Text Blocks as a standard feature in javac

[Jim Laskey]

Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241741/webrev-01 <http://cr.openjdk.java.net/~jlaskey/8241741/webrev-01>

> On Apr 6, 2020, at 11:41 AM, Jan Lahoda <jan.lahoda at oracle.com> wrote:
> 
> Hi Jim,
> 
> The changes to:
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_ja.properties
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties
> 
> Probably mean text blocks will be allowed to all source levels (i.e. also for --release 14; --release 8; etc.) Is that intentional?
> 
> Also, for tests like (but also many others):
> test/jdk/java/lang/String/Formatted.java
> 
> why keep "@run main/othervm"? Should just "@run main" work as well (but faster)?
> 
> Jan
> 
> On 06. 04. 20 16:33, Jim Laskey wrote:
>> Please take the time to review the code changes to make Text Blocks a standard feature for Java. The changes are pretty light-weight and shouldn't take too long to review. Mostly involves removing "preview" trappings.
>> Cheers,
>> -- Jim
>> webrev: http://cr.openjdk.java.net/~jlaskey/8241741/webrev-00
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8241741
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8241745
>> JEP: https://bugs.openjdk.java.net/browse/JDK-8236934

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20200406/ca42dead/attachment.htm>