RFR: JDK-8035787: SourcePositions are wrong for Strings concatenated with '+' operator

Jan Lahoda jan.lahoda at oracle.com
Tue Apr 7 12:10:28 UTC 2020

Looks good to me, Liam.



On 07. 04. 20 0:48, Liam Miller-Cushon wrote:
> Hi,
> Please consider this change to add a regression test for start position 
> handling of folding string literals.The associated bug (JDK-8035787) was 
> fixed by more recent improvements to string literal folding 
> (JDK-8134007), this patch just adds a regression test to ensure the 
> start positions continue to be correct.
> (JDK-8035787 also mentions an issue with end positions for string 
> literals in single-element annotations, but as discussed in the bug that 
> part appears to be working as intended.)
> bug: https://bugs.openjdk.java.net/browse/JDK-8035787
> webrev: http://cr.openjdk.java.net/~cushon/8035787/webrev.00/
> Thanks,
> Liam

More information about the compiler-dev mailing list