RFR: JDK-8035787: SourcePositions are wrong for Strings concatenated with '+' operator

[Liam Miller-Cushon]

Thanks for the review!

On Tue, Apr 7, 2020 at 5:10 AM Jan Lahoda <jan.lahoda at oracle.com> wrote:

> Looks good to me, Liam.
>
> Thanks!
>
> Jan
>
> On 07. 04. 20 0:48, Liam Miller-Cushon wrote:
> > Hi,
> >
> > Please consider this change to add a regression test for start position
> > handling of folding string literals.The associated bug (JDK-8035787) was
> > fixed by more recent improvements to string literal folding
> > (JDK-8134007), this patch just adds a regression test to ensure the
> > start positions continue to be correct.
> >
> > (JDK-8035787 also mentions an issue with end positions for string
> > literals in single-element annotations, but as discussed in the bug that
> > part appears to be working as intended.)
> >
> > bug: https://bugs.openjdk.java.net/browse/JDK-8035787
> > webrev: http://cr.openjdk.java.net/~cushon/8035787/webrev.00/
> >
> > Thanks,
> > Liam
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20200407/0f847e37/attachment.htm>