RFR: 8231622: SuppressWarning("serial") ignored on field serialVersionUID [v3]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Wed Dec 9 08:04:49 UTC 2020


On Tue, 8 Dec 2020 17:30:53 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Revise tests by using library toolbox.
>>  - Merge remote-tracking branch 'origin' into JDK-8231622
>>  - Revise test cases. Remove legal header and add /nodynamiccopyright/
>>  - 8231622: SuppressWarning(serial) ignored on field serialVersionUID
>
> test/langtools/tools/javac/T8231622/T8231622.java line 79:
> 
>> 77:         if (!Objects.equals(output, expected)) {
>> 78:             throw new AssertionError("incorrect output\nactual=" + output + "\nexpected=" + expected);
>> 79:         }
> 
> ToolBox provides `checkEquals` which provides a more detailed error message in the case of a difference.

Thank you for the suggestion. I fixed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1626


More information about the compiler-dev mailing list