RFR: 8231622: SuppressWarning("serial") ignored on field serialVersionUID [v3]

Thu Dec 10 13:12:37 UTC 2020

On Tue, 8 Dec 2020 17:32:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Revise tests by using library toolbox.
>>  - Merge remote-tracking branch 'origin' into JDK-8231622
>>  - Revise test cases. Remove legal header and add /nodynamiccopyright/
>>  - 8231622: SuppressWarning(serial) ignored on field serialVersionUID
>
> Nice improvement. You can make it even better in 3 places by using `ToolBox.checkEquals`, which provides more detailed reporting in the case of a difference being found.

> Anyway, I don't think we should continue to discuss the concrete content in this patch.

@jonathan-gibbons I submit a patch[1] to solve the previous bad style tests. We can continue the discussion there.

[1] https://github.com/openjdk/jdk/pull/1732

-------------

PR: https://git.openjdk.java.net/jdk/pull/1626