RFR: 8255968: Confusing error message for inaccessible constructor [v3]

[Maurizio Cimadamore]

On Wed, 25 Nov 2020 13:44:31 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Change the `Test(String x)` from private to default. Add comments in test cases to improve readability.
>>  - Add corresponding tests for the method reference cases.
>>  - Add comments to state the situations
>
> I left some additional comments on tests. I plan to do some experiments to validate that we are not going to introduce bad regressions.

> @mcimadamore Do you agree with this style?

Yeah - of course nesting things is gonna mess up with access checks - sorry for sending you down the wrong direction!

You could prefix every class in the test with `T8255968_1` e.g.

class T8255968_1 {
    T8255968Test1 c = new T8255968_1_Test(0);
}

class T8255968_1_Test {
    private T8255968_1_Test(int x) {}
}

-------------

PR: https://git.openjdk.java.net/jdk/pull/1389