RFR: 8255968: Confusing error message for inaccessible constructor [v3]
Guoxiong Li
github.com+13688759+lgxbslgx at openjdk.java.net
Thu Nov 26 15:21:55 UTC 2020
On Wed, 25 Nov 2020 18:51:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> I left some additional comments on tests. I plan to do some experiments to validate that we are not going to introduce bad regressions.
>
>> @mcimadamore Do you agree with this style?
>
> Yeah - of course nesting things is gonna mess up with access checks - sorry for sending you down the wrong direction!
>
> You could prefix every class in the test with `T8255968_1` e.g.
>
> class T8255968_1 {
> T8255968Test1 c = new T8255968_1_Test(0);
> }
>
> class T8255968_1_Test {
> private T8255968_1_Test(int x) {}
> }
I update the code about test cases. Thank you for taking the time to review.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1389
More information about the compiler-dev
mailing list