RFR: 8253736: Cleanup some of WorkArounds and usage thereof

Jonathan Gibbons jjg at openjdk.java.net
Fri Oct 2 16:21:44 UTC 2020


On Thu, 1 Oct 2020 23:23:54 GMT, Kumar Srinivasan <ksrini at openjdk.org> wrote:

>> This cleanup is primarily focussed on the WorkArounds class, simplifying/removing code that is no longer required.
>> 
>> Also, simplified DocLint initialization such that it no longer needs a `JavacTask` and so the initialization code can
>> be moved out of `WorkArounds`.
>> The "constant value expression" in Utils is simplified to remove a redundant level of enclosing nested class for the
>> type-kind visitor.
>
> test/langtools/jdk/javadoc/doclet/constantValues/TestConstantValuesDriver.java line 60:
> 
>> 58:                     <code id="TestConstantValues.BYTE_MAX_VALUE">public static final byte</code></td>
>> 59:                     <th class="col-second" scope="row"><code><a
>> href="TestConstantValues.html#BYTE_MAX_VALUE">BYTE_MAX_VALUE</a></code></th> 60:                     <td
>> class="col-last"><code>0x7f</code></td>""",
> 
> Should there be tests for Float, Double, Long ?

https://bugs.openjdk.java.net/browse/JDK-8253941

-------------

PR: https://git.openjdk.java.net/jdk/pull/412


More information about the compiler-dev mailing list