RFR: 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows

[Jonathan Gibbons]

On Thu, 1 Oct 2020 12:40:07 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> @rwestberg  prepared a script that runs various tests in GitHub Actions. But, sadly, with a recently proposed fix for
> Windows handling (see https://github.com/openjdk/jdk/pull/437), the SourceLauncherTest is failing (the
> testNoSourceOnClassPath sub-test): https://github.com/rwestberg/jdk/runs/1188397548
> I don't think this has much to do with javac (or source launcher) itself - the test fails while it tries to write the
> test source file, before the source launcher is invoked. So this patch tries to: a) avoid doing that; b)  improve
> ToolBox to check and reject file names that are reserved.  Note that testHelloWorldWithAux uses the name "Aux"
> intentionally, and it passes because it never actually writes file with name "Aux" - the source file will be (I
> believe) named "HelloWorld", and while it will contain also a class named "Aux", the classfile will only ever exist in
> memory, and won't be written as a file, so will not cause the issue.  The use of name "Aux" in the
> testNoSourceOnClassPath test does not seem to be necessary, and the issue happens in the test set-up, not while doing
> the actual test, so it seems fine to change the name.  @jonathan-gibbons, could you please take a look? Thanks!

Marked as reviewed by jjg (Reviewer).

test/langtools/tools/lib/toolbox/ToolBox.java line 729:

> 727:             }
> 728:         }
> 729:     }

nice

-------------

PR: https://git.openjdk.java.net/jdk/pull/456