RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v4]

Jan Lahoda jlahoda at openjdk.java.net
Thu Oct 29 09:46:46 UTC 2020

On Fri, 23 Oct 2020 18:19:13 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>>   Removing unnecessary cast.
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java line 2848:
>> 2846:         UnknownInlineTagTree previewTag = (UnknownInlineTagTree) t;
>> 2847:         List<? extends DocTree> previewContent = previewTag.getContent();
>> 2848:         String previewText = ((TextTree) previewContent.get(0)).getBody();
> This looks unreasonably fragile. And, I thought the tag was going away... at least according to earlier files in this review.

This was intended to allow Preview APIs to provide their own text instead of the generic one. But, looking again at JEP 12, this shouldn't be supported, so removing.


PR: https://git.openjdk.java.net/jdk/pull/703

More information about the compiler-dev mailing list