RFR: 8241187: ToolBox::grep should allow for negative filtering [v3]

Guoxiong Li gli at openjdk.java.net
Fri Apr 23 12:01:31 UTC 2021


> Hi all,
> 
> This patch adds two methods in `ToolBox` to do the negative filtering. Although the label `noreg-self` was added, I write a test for this enhancement to verify the code. And the method name `grepNotMatch` may need to be improved. Any idea is appreciated.
>  
> Thank you for taking the time to review.
> 
> Best Regards.

Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Use meaningful class name
 - Merge branch 'master' into JDK-8241187
 - Revise method and test.
 - 8241187: ToolBox::grep should allow for negative filtering

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1934/files
  - new: https://git.openjdk.java.net/jdk/pull/1934/files/f55e8a3a..f1ae6684

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1934&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1934&range=01-02

  Stats: 375357 lines in 8680 files changed: 198659 ins; 120636 del; 56062 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1934.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1934/head:pull/1934

PR: https://git.openjdk.java.net/jdk/pull/1934


More information about the compiler-dev mailing list