RFR: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries [v3]
Guoxiong Li
gli at openjdk.java.net
Fri Apr 23 12:41:13 UTC 2021
> Hi all,
>
> javac fails to read modifiers from the MethodParameters attribute in class files, which prevents plugins from accessing those modifiers across compilation boundaries. Because `com.sun.tools.javac.jvm.ClassReader` doesn't read and store the access flags(modifiers) from MethodParameters attribute.
>
> This patch fixes it and adds a corresponding test case. All the existing tests of javac passed locally.
>
> Thank you for taking the time to review.
>
> Best Regards.
Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Use meaningful class name and update copyright
- Merge branch 'master' into JDK-8226216
- Modify legal header. Fix typo.
- 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1890/files
- new: https://git.openjdk.java.net/jdk/pull/1890/files/a074937f..6fb16609
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1890&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1890&range=01-02
Stats: 379711 lines in 8961 files changed: 199371 ins; 123615 del; 56725 mod
Patch: https://git.openjdk.java.net/jdk/pull/1890.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1890/head:pull/1890
PR: https://git.openjdk.java.net/jdk/pull/1890
More information about the compiler-dev
mailing list