RFR: 8140442: Add getOutermostTypeElement to javax.lang.model utility class
Jan Lahoda
jlahoda at openjdk.java.net
Tue Aug 10 13:00:30 UTC 2021
On Wed, 4 Aug 2021 22:41:22 GMT, Joe Darcy <darcy at openjdk.org> wrote:
> Please review this change to add a getOutermostTypeElement method to javax.lang.model.Elements along with the corresponding CSR https://bugs.openjdk.java.net/browse/JDK-8271903.
To me, looks good, with some nits inlined.
src/java.compiler/share/classes/javax/lang/model/util/Elements.java line 581:
> 579: // for misbehaving element implementations.
> 580: while (true) {
> 581: // Conceptual instanceof TypeElment check. If the
Nit:
Suggestion:
// Conceptual instanceof TypeElement check. If the
test/langtools/tools/javac/processing/model/util/elements/TestOutermostTypeElement.java line 78:
> 76: @Override
> 77: public Void scan(Element e, Elements elts) {
> 78: // System.out.println(e.getSimpleName() + " " + e.getKind());
Nit:
Suggestion:
-------------
Marked as reviewed by jlahoda (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5007
More information about the compiler-dev
mailing list