RFR: 8140442: Add getOutermostTypeElement to javax.lang.model utility class [v3]

Joe Darcy darcy at openjdk.java.net
Tue Aug 10 16:46:00 UTC 2021


On Tue, 10 Aug 2021 12:55:52 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8140442
>>  - Respond to review feedback and update copyright.
>>  - Appease jcheck.
>>  - Now with tests and javac Elements implementation.
>>  - Merge branch 'master' into JDK-8140442
>>  - Merge branch 'master' into JDK-8140442
>>  - Initial version pre-tests.
>
> src/java.compiler/share/classes/javax/lang/model/util/Elements.java line 581:
> 
>> 579:             // for misbehaving element implementations.
>> 580:             while (true) {
>> 581:                 // Conceptual instanceof TypeElment check. If the
> 
> Nit:
> Suggestion:
> 
>                 // Conceptual instanceof TypeElement check. If the

Nits fixed; thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5007


More information about the compiler-dev mailing list