RFR: 8266666: Implementation for snippets [v7]

[Pavel Rappo]

On Fri, 20 Aug 2021 18:13:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Pass through FIXMEs and TODOs
>>   
>>   Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes those FIXMEs completely. For example, unlike Style hierarchy, Action hierarchy won't benefit from becoming sealed. So the respective FIXME is removed.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/SnippetTaglet.java line 260:
> 
>> 258:      * There's a separate issue of mapping discrepancies back to their
>> 259:      * originating source in the doc comment and the external file. Maybe there
>> 260:      * is a value in it, or may be there isn't. In any case, accurate mapping
> 
> "maybe"

Fixed in a7cd155.

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Parser.java line 134:
> 
>> 132:             this.eolMarker = eolMarker;
>> 133:             // capture the rightmost eolMarker (e.g. "//")
>> 134:             // The bellow Pattern.compile should never throw PatternSyntaxException
> 
> "below" ?

Fixed in a7cd155.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4795