RFR: 8266666: Implementation for snippets [v7]

Pavel Rappo prappo at openjdk.java.net
Tue Aug 24 11:33:33 UTC 2021


On Fri, 20 Aug 2021 18:07:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Pass through FIXMEs and TODOs
>>   
>>   Downgrades FIXMEs that do not mark *feature issues* to TODOs, or removes those FIXMEs completely. For example, unlike Style hierarchy, Action hierarchy won't benefit from becoming sealed. So the respective FIXME is removed.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties line 360:
> 
>> 358: 
>> 359: doclet.tag.attribute.repeated=\
>> 360:  repeated attribute: "{0}"
> 
> check the resource file for other quoted values; I think you'll find single quotes are the prevailing standard.

I didn't find single quotes to be the prevailing standard neither in `doclet.properties` nor in `compiler.properties`. In fact, it seems to be the opposite: whenever a parameter (not constant) is output, it's either unquoted or double-quoted. Did I look in the right place?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4795


More information about the compiler-dev mailing list