RFR: 8231436: Fix the applicability of a no- at Target annotation type

Liam Miller-Cushon cushon at openjdk.java.net
Mon Feb 1 20:53:43 UTC 2021

On Mon, 1 Feb 2021 20:40:54 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Hi Liam,
>> Code looks good, but I'd prefer if you file a more specific bug. Maybe also add a small test that doesn't compile before the fix?
> Please file a CSR so that the behavioral compatibly change can be assessed.

Thanks for the comments,

@jbf I'll add a more focused test. For the bug, the original discussion in https://mail.openjdk.java.net/pipermail/compiler-dev/2019-September/013705.html is specifically about annotations without an explicit `@Target` applying to `MODULE`, I don't think there's anything that needs to be done for [JDK-8231436](https://bugs.openjdk.java.net/browse/JDK-8231436) besides supporting `MODULE`, would you still prefer a separate bug?

@jddarcy note that there was already a spec change related to this in [JDK-8231435](https://bugs.openjdk.java.net/browse/JDK-8231435) and the spec bug mentions "this expansion is source, binary, and behaviorally compatible", should I still file a CSR?


PR: https://git.openjdk.java.net/jdk/pull/2303

More information about the compiler-dev mailing list