RFR: 8231436: Fix the applicability of a no- at Target annotation type
Joel Borggrén-Franck
jfranck at openjdk.java.net
Tue Feb 2 09:31:43 UTC 2021
On Mon, 1 Feb 2021 20:50:41 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
>> Please file a CSR so that the behavioral compatibly change can be assessed.
>
> Thanks for the comments,
>
> @jbf I'll add a more focused test. For the bug, the original discussion in https://mail.openjdk.java.net/pipermail/compiler-dev/2019-September/013705.html is specifically about annotations without an explicit `@Target` applying to `MODULE`, I don't think there's anything that needs to be done for [JDK-8231436](https://bugs.openjdk.java.net/browse/JDK-8231436) besides supporting `MODULE`, would you still prefer a separate bug?
>
> @jddarcy note that there was already a spec change related to this in [JDK-8231435](https://bugs.openjdk.java.net/browse/JDK-8231435) and the spec bug mentions "this expansion is source, binary, and behaviorally compatible", should I still file a CSR?
>From this follow up here: https://mail.openjdk.java.net/pipermail/compiler-dev/2019-September/013715.html my interpretation is that this bug was intended to widen it to all contexts, including type use. This has been changed in JLS but not in the normative javadoc and also not in the compiler. I believe we should keep declarations only, and back out the change to JLS.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2303
More information about the compiler-dev
mailing list