RFR: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient [v2]

Jonathan Gibbons jjg at openjdk.java.net
Sat Jan 2 22:31:55 UTC 2021

On Mon, 21 Dec 2020 09:34:59 GMT, Joel Borggrén-Franck <jfranck at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>   Use Objects::checkFromIndexSize
> I'd like to see some kind of evidence that performance was actually improved. I realise this might be hard to make a good standalone test for, but it should be doable as an experiment observing how many times write(int) is called for a huge file.

I read Joel's (@jbf) comment as understanding where you are coming from with the patch.

Since the code now provides the recommended pattern, I don't think any more evidence is needed. I think you're OK to integrate.


PR: https://git.openjdk.java.net/jdk/pull/1854

More information about the compiler-dev mailing list