RFR: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient [v2]

[Guoxiong Li]

On Mon, 21 Dec 2020 09:34:59 GMT, Joel Borggrén-Franck <jfranck at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Objects::checkFromIndexSize
>
> I'd like to see some kind of evidence that performance was actually improved. I realise this might be hard to make a good standalone test for, but it should be doable as an experiment observing how many times write(int) is called for a huge file.

As @jbf said:

> I'd like to see some kind of evidence that performance was actually improved.

But later @jbf said:

>  Ok, got it. So today, in case the stream has an efficient write of an array range it currently isn't called, but a 1-byte-at-a-time write inherited is called instead. This patch delegates to the out method (efficient or not) instead of choosing the inherited method (always inefficient).

Currently, @jbf doesn't approve this patch.

@jonathan-gibbons @jbf Should I submit more evidence? Or should I integrate this patch?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1854