RFR: 8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh [v2]

Guoxiong Li github.com+13688759+lgxbslgx at openjdk.java.net
Thu Jan 7 10:15:17 UTC 2021

> Hi all,
> This patch rewrites Diagnostics.sh to java code by using ToolBox API.
> And I have a question: What does the `elts` mean in the following comments? Is it `elements`?
> I think that a meaningful name should be used.
> // Warn for missing elts in user-specified paths
> // No warning for missing elts in "system" paths
> Thank you for taking the time to review.
> Best Regards.

Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:

  Modify elts to elements. Use correct line separator.


  - all: https://git.openjdk.java.net/jdk/pull/1959/files
  - new: https://git.openjdk.java.net/jdk/pull/1959/files/7f2de0ff..ae0379b6

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1959&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1959&range=00-01

  Stats: 14 lines in 1 file changed: 4 ins; 0 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1959.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1959/head:pull/1959

PR: https://git.openjdk.java.net/jdk/pull/1959

More information about the compiler-dev mailing list