RFR: 8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh

[Guoxiong Li]

On Wed, 6 Jan 2021 14:54:13 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch rewrites Diagnostics.sh to java code by using ToolBox API.
>> And I have a question: What does the `elts` mean in the following comments? Is it `elements`?
>> I think that a meaningful name should be used.
>> 
>> // Warn for missing elts in user-specified paths
>> // No warning for missing elts in "system" paths
>> 
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
>> This patch rewrites Diagnostics.sh to java code by using ToolBox API.
>> And I have a question: What does the elts mean in the following comments? Is it elements?
>> I think that a meaningful name should be used.
> 
> Brave person. There's a reason no one has converted this test so far.
> 
> To answer your specific question: yes, `elts` should be read as an abbreviation for `elements` and yes, it would be good to clarify it.

@jonathan-gibbons Thank you for your answer. I modify `elts` to `elements`.

And I revise the test code about line separator because the test failed at windows in the pre-submit tests.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1959