RFR: 8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh [v2]

Guoxiong Li gli at openjdk.java.net
Sat Jun 12 17:46:50 UTC 2021


On Thu, 7 Jan 2021 10:15:17 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch rewrites Diagnostics.sh to java code by using ToolBox API.
>> And I have a question: What does the `elts` mean in the following comments? Is it `elements`?
>> I think that a meaningful name should be used.
>> 
>> 
>> // Warn for missing elts in user-specified paths
>> // No warning for missing elts in "system" paths
>> 
>> 
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Modify elts to elements. Use correct line separator.

I merged the `master` branch to run the test locally and the test passed.

Ping for review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1959


More information about the compiler-dev mailing list