RFR: 8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh [v3]

Guoxiong Li gli at openjdk.java.net
Sat Jun 12 17:46:49 UTC 2021


> Hi all,
> 
> This patch rewrites Diagnostics.sh to java code by using ToolBox API.
> And I have a question: What does the `elts` mean in the following comments? Is it `elements`?
> I think that a meaningful name should be used.
> 
> 
> // Warn for missing elts in user-specified paths
> // No warning for missing elts in "system" paths
> 
> 
> Thank you for taking the time to review.
> 
> Best Regards.

Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into JDK-8150303
 - Modify elts to elements. Use correct line separator.
 - 8150303: Rewrite test/tools/javac/Paths/Diagnostics.sh

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1959/files
  - new: https://git.openjdk.java.net/jdk/pull/1959/files/ae0379b6..d0ae2f3c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1959&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1959&range=01-02

  Stats: 1487467 lines in 16132 files changed: 734236 ins; 670895 del; 82336 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1959.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1959/head:pull/1959

PR: https://git.openjdk.java.net/jdk/pull/1959


More information about the compiler-dev mailing list