RFR: 8241187: ToolBox::grep should allow for negative filtering [v3]

[Vicente Romero]

On Fri, 23 Apr 2021 12:01:31 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch adds two methods in `ToolBox` to do the negative filtering. Although the label `noreg-self` was added, I write a test for this enhancement to verify the code. And the method name `grepNotMatch` may need to be improved. Any idea is appreciated.
>>  
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Use meaningful class name
>  - Merge branch 'master' into JDK-8241187
>  - Revise method and test.
>  - 8241187: ToolBox::grep should allow for negative filtering

looks good to me with minor suggestion

test/langtools/tools/lib/toolbox/ToolBox.java line 208:

> 206:      * @return the strings matching(or not matching) the regular expression
> 207:      */
> 208:     public List<String> grep(Pattern pattern, List<String> lines, boolean invert) {

what about?


    public List<String> grep(Pattern pattern, List<String> lines, boolean invert) {
        return lines.stream()
                .filter(s -> invert ? !pattern.matcher(s).find() : pattern.matcher(s).find())
                .collect(Collectors.toList());
    }

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1934