RFR: 8241187: ToolBox::grep should allow for negative filtering [v3]

[Guoxiong Li]

On Tue, 11 May 2021 03:37:48 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Use meaningful class name
>>  - Merge branch 'master' into JDK-8241187
>>  - Revise method and test.
>>  - 8241187: ToolBox::grep should allow for negative filtering
>
> looks good to me with minor suggestion

@vicente-romero-oracle @jonathan-gibbons Thanks for your review. I revised the code according to your suggestion.

> test/langtools/tools/lib/toolbox/ToolBox.java line 208:
> 
>> 206:      * @return the strings matching(or not matching) the regular expression
>> 207:      */
>> 208:     public List<String> grep(Pattern pattern, List<String> lines, boolean invert) {
> 
> what about?
> 
> 
>     public List<String> grep(Pattern pattern, List<String> lines, boolean invert) {
>         return lines.stream()
>                 .filter(s -> invert ? !pattern.matcher(s).find() : pattern.matcher(s).find())
>                 .collect(Collectors.toList());
>     }

Putting the `invert` into method `filter` may cause a little performance influence. Is it similar to `loop`? 
Because this is the test code, I adopt your suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1934