RFR: 8267570: The comment of the class JavacParser is not appropriate [v2]

Guoxiong Li gli at openjdk.java.net
Sun May 23 08:19:29 UTC 2021


> Hi all,
> 
> The following comment of the class JavacParser is not appropriate.
> 
> 
> It operates by recursive descent, with code derived
> systematically from an LL(1) grammar.
> 
> 
> From the source code, the current javac parser looks like a LL(K) parser instead of LL(1).
> This patch revises the comment so that developers won't be confused by it.
> 
> Thank you for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:

  Revise comment

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4153/files
  - new: https://git.openjdk.java.net/jdk/pull/4153/files/afc12850..c5f012a8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4153&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4153&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4153.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4153/head:pull/4153

PR: https://git.openjdk.java.net/jdk/pull/4153


More information about the compiler-dev mailing list