RFR: 8267570: The comment of the class JavacParser is not appropriate [v2]

Jonathan Gibbons jjg at openjdk.java.net
Thu May 27 00:27:06 UTC 2021


On Sun, 23 May 2021 08:19:29 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> The following comment of the class JavacParser is not appropriate.
>> 
>> 
>> It operates by recursive descent, with code derived
>> systematically from an LL(1) grammar.
>> 
>> 
>> From the source code, the current javac parser looks like a LL(K) parser instead of LL(1).
>> This patch revises the comment so that developers won't be confused by it.
>> 
>> Thank you for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revise comment

Marked as reviewed by jjg (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4153


More information about the compiler-dev mailing list