RFR: 8230623: Extract command-line help for -Xlint sub-options to new --help-lint [v4]

[Jonathan Gibbons]

On Tue, 11 May 2021 02:41:16 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch splits out the concrete keys of -Xlint into a new option, --help-lint, 
>> so that the output of --help-extra is kept clean and concise.
>> 
>> Thank you for taking the time to review.
>> 
>> Best Regards.
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into JDK-8230623
>  - Update copyright
>  - Merge branch 'master' into JDK-8230623
>  - Remove the content in documentation javac.1
>  - 8230623: Extract command-line help for -Xlint sub-options to new --help-lint

Approved, with some minor suggestions to improve the text in the resource file.

Thanks for hanging in there with this one.

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 175:

> 173:     Warnings to enable or disable, separated by comma.\n\
> 174:     Precede a key by '-' to disable the specified warning.\n\
> 175:     Use option --help-lint to see the supported keys.

Suggest removing the word "option".
This does not affect the CSR.

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 296:

> 294:     Print this help message
> 295: javac.opt.help.lint=\
> 296:     Print the supported keys of option -Xlint

Suggest: `Print the supported keys for -Xlint`
This does not affect the CSR.

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 298:

> 296:     Print the supported keys of option -Xlint
> 297: javac.opt.help.lint.header=\
> 298:     The supported keys of option -Xlint are:

Suggest: `The supported keys for -Xlint are:`
This does not affect the CSR.

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1758