RFR: 8230623: Extract command-line help for -Xlint sub-options to new --help-lint [v4]
Guoxiong Li
gli at openjdk.java.net
Thu May 27 08:19:29 UTC 2021
On Thu, 27 May 2021 00:54:25 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'master' into JDK-8230623
>> - Update copyright
>> - Merge branch 'master' into JDK-8230623
>> - Remove the content in documentation javac.1
>> - 8230623: Extract command-line help for -Xlint sub-options to new --help-lint
>
> Approved, with some minor suggestions to improve the text in the resource file.
>
> Thanks for hanging in there with this one.
@jonathan-gibbons Thanks for your review. I revised the resource file according to your suggestions.
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 175:
>
>> 173: Warnings to enable or disable, separated by comma.\n\
>> 174: Precede a key by '-' to disable the specified warning.\n\
>> 175: Use option --help-lint to see the supported keys.
>
> Suggest removing the word "option".
> This does not affect the CSR.
Fixed.
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 296:
>
>> 294: Print this help message
>> 295: javac.opt.help.lint=\
>> 296: Print the supported keys of option -Xlint
>
> Suggest: `Print the supported keys for -Xlint`
> This does not affect the CSR.
Fixed.
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 298:
>
>> 296: Print the supported keys of option -Xlint
>> 297: javac.opt.help.lint.header=\
>> 298: The supported keys of option -Xlint are:
>
> Suggest: `The supported keys for -Xlint are:`
> This does not affect the CSR.
Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1758
More information about the compiler-dev
mailing list