RFR: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec [v2]
Jan Lahoda
jlahoda at openjdk.java.net
Fri May 28 19:07:18 UTC 2021
On Thu, 27 May 2021 11:26:14 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reordering @implSpec and example as suggested.
>
> src/jdk.compiler/share/classes/com/sun/source/util/DocTreeScanner.java line 38:
>
>> 36: * nodes.
>> 37: *
>> 38: * @implSpec
>
> 1. Should the error-counting example in the immediately following paragraph belong to this `@implSpec` section?
> 2. Why is there no similar `@implSpec` section being added to the class-level doc comment of TreeScanner? If such a section is to be added, then should the identifier-counting example in the immediately following paragraph belong to that section?
Thanks for the comment, Pavel. I've tried to do the changes in an update:
https://github.com/openjdk/jdk/pull/4223/commits/5c9f694fade7380fa1a7ae667cf4acd5be60c244
-------------
PR: https://git.openjdk.java.net/jdk/pull/4223
More information about the compiler-dev
mailing list