RFR: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec [v2]

Jan Lahoda jlahoda at openjdk.java.net
Fri May 28 19:07:17 UTC 2021


> As noted in:
> https://bugs.openjdk.java.net/browse/JDK-8265981?focusedCommentId=14423316&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14423316
> 
> Methods in various utility visitor classes in jdk.compiler should use @implSpec to specify the implementation behavior. This patch tries to add the @implSpec tag to methods which already contain a text specifying the implementation, and adds new javadoc to the handful of methods that are missing it so far.
> 
> The CSR is started for review here:
> https://bugs.openjdk.java.net/browse/JDK-8267838

Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:

  Reordering @implSpec and example as suggested.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4223/files
  - new: https://git.openjdk.java.net/jdk/pull/4223/files/d27a84a0..5c9f694f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4223&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4223&range=00-01

  Stats: 57 lines in 2 files changed: 29 ins; 28 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4223.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4223/head:pull/4223

PR: https://git.openjdk.java.net/jdk/pull/4223


More information about the compiler-dev mailing list