RFR: 8272234: Pass originating elements from Filer to JavaFileManager [v4]

Jan Lahoda jlahoda at openjdk.java.net
Tue Oct 19 16:43:16 UTC 2021


> This is a first prototype of a patch that propagates originating elements from `Filer` (`createSourceFile`/`createClassFile`/`createResource`) to the corresponding methods in `JavaFileManager`. As file managers generally don't know about `Element`s, the `Element`s are first converted to their corresponding `FileObject`s (if any). As the currently existing methods only take one `FileObject` as a sibling of the newly created file, a new set of methods is proposed that take multiple originating files.
> 
> Any feedback on this prototype would be welcome.

Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:

  Fixing typo, as per review comments.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5076/files
  - new: https://git.openjdk.java.net/jdk/pull/5076/files/f871a30c..aa31c17a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5076&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5076&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5076.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5076/head:pull/5076

PR: https://git.openjdk.java.net/jdk/pull/5076


More information about the compiler-dev mailing list