RFR: 8272234: Pass originating elements from Filer to JavaFileManager [v4]

Vicente Romero vromero at openjdk.java.net
Tue Oct 19 20:24:45 UTC 2021


On Tue, 19 Oct 2021 16:43:16 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> This is a first prototype of a patch that propagates originating elements from `Filer` (`createSourceFile`/`createClassFile`/`createResource`) to the corresponding methods in `JavaFileManager`. As file managers generally don't know about `Element`s, the `Element`s are first converted to their corresponding `FileObject`s (if any). As the currently existing methods only take one `FileObject` as a sibling of the newly created file, a new set of methods is proposed that take multiple originating files.
>> 
>> Any feedback on this prototype would be welcome.
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing typo, as per review comments.

I made some minor edits to the CSR and added myself as reviewer

-------------

PR: https://git.openjdk.java.net/jdk/pull/5076


More information about the compiler-dev mailing list