RFR: 8289647: AssertionError during annotation processing of record related tests [v2]
Aggelos Biboudis
abimpoudis at openjdk.org
Fri Jul 29 13:58:26 UTC 2022
On Thu, 28 Jul 2022 15:14:54 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add bug id at existing test
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java line 1506:
>
>> 1504: }
>> 1505:
>> 1506: public RecordComponent findRecordComponentToRemove(JCVariableDecl var) {
>
> given that this method has only one client and it is simple, consider inlining its code in the client code
`pos` has private access in `com.sun.tools.javac.code.Symbol.RecordComponent`. Is it ok if we bump it to `public` (it still hides the one from `VarSymbol`. WDYT?
-------------
PR: https://git.openjdk.org/jdk/pull/9570
More information about the compiler-dev
mailing list