RFR: 8289647: AssertionError during annotation processing of record related tests [v2]

Vicente Romero vromero at openjdk.org
Fri Jul 29 14:42:48 UTC 2022


On Fri, 29 Jul 2022 13:55:00 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java line 1506:
>> 
>>> 1504:         }
>>> 1505: 
>>> 1506:         public RecordComponent findRecordComponentToRemove(JCVariableDecl var) {
>> 
>> given that this method has only one client and it is simple, consider inlining its code in the client code
>
> `pos` has private access in `com.sun.tools.javac.code.Symbol.RecordComponent`. Is it ok if we bump it to `public` (it still hides the one from `VarSymbol`. WDYT?

Oh I see then better to leave the code as it is now

-------------

PR: https://git.openjdk.org/jdk/pull/9570


More information about the compiler-dev mailing list