RFR: JDK-8290901: Reduce use of -source in langtools tests [v4]

Jonathan Gibbons jjg at openjdk.org
Fri Jul 29 16:21:00 UTC 2022


On Fri, 29 Jul 2022 00:53:44 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> To a first approximation, this change replaces use of "-source", where possible, with the preferable "--release" javac option. (There are cases where this swap is not desirable, such as when newer library features are being used in the test.)
>> 
>> A few unneeded uses of -source were removed entirely.
>> 
>> I'll update copyrights before any push.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove one more unneeded -Xlint:-options usage.

generally, a nice cleanup, but check out `NestedCapture.java`

test/langtools/tools/javac/generics/inference/NestedCapture.java line 29:

> 27:  * @summary Capture variable passed through multiple levels of nested inference
> 28:  * @compile NestedCapture.java
> 29:  * @compile NestedCapture.java

Did too much get removed here?   Should there be a `--release 7`?

-------------

PR: https://git.openjdk.org/jdk/pull/9622


More information about the compiler-dev mailing list