8043179: Lambda expression can mutate final field

[Archie Cobbs]

Hi folks,

On Sun, Sep 25, 2022 at 4:02 PM Archie Cobbs <archie.cobbs at gmail.com> wrote:

> then the good news is that this is an easy three line fix
> <https://github.com/openjdk/jdk/pull/10381/files#diff-8973dfc1d0ee2ff1319d8753daec3f0be7e9bd0a63e9512c38a0eeed68e5bcaa>
>

I'm still looking for any thoughts or comments on this proposed fix for
8043179.

I'm also looking for someone who is willing to consider being a sponsor for
me. I've got this PR and a couple of other fixes in the hopper. In return I
promise to be a good listener and hopefully a net positive contributor.

Also, I have a question - is anyone else having trouble building the JDK on
macos 12.6 and Xcode 14.0?

I'm getting two build failures in the latest code
jdk-20+17-23-g0d8e3ce6b6e, one in GTest and one in JniInvocationTest.

The GTest build errors start like this:

Creating hotspot/variant-server/libjvm/gtest/gtestLauncher from 1 file(s)
In file included from /Users/archie/proj/googletest/
googlemock/src/gmock-all.cc:39:
In file included from /Users/archie/proj/googletest/
googlemock/include/gmock/gmock.h:59:
/Users/archie/proj/googletest/googlemock/include/gmock/gmock-actions.h:484:3:
error: definition of implicit copy constructor for
'PolymorphicAction<testing::internal::ReturnNullAction>' is deprecated
because it has a user-declared copy assignment operator
[-Werror,-Wdeprecated-copy]
  GTEST_DISALLOW_ASSIGN_(PolymorphicAction);
  ^
/Users/archie/proj/googletest/googletest/include/gtest/internal/gtest-port.h:928:8:
note: expanded from macro 'GTEST_DISALLOW_ASSIGN_'
  void operator=(type const &) GTEST_CXX11_EQUALS_DELETE_
       ^
/Users/archie/proj/googletest/googlemock/include/gmock/gmock-actions.h:1125:10:
note: in implicit copy constructor for 'testing::PolymorphicAction<
testing::internal::ReturnNullAction>' first required here
  return MakePolymorphicAction(internal::ReturnNullAction());
         ^

These are the JniInvocationTest errors:

Creating support/test/jdk/jtreg/native/bin/JniInvocationTest from 1 file(s)
/Users/archie/proj/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:3441:132:
error: parameter 'SizeOfTag' set but not used
[-Werror,-Wunused-but-set-parameter]
void *Type_ProfileSequenceId_Read(struct _cms_typehandler_struct* self,
cmsIOHANDLER* io, cmsUInt32Number* nItems, cmsUInt32Number SizeOfTag)

                                                       ^
/Users/archie/proj/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:5137:125:
error: parameter 'SizeOfTag' set but not used
[-Werror,-Wunused-but-set-parameter]
void *Type_Dictionary_Read(struct _cms_typehandler_struct* self,
cmsIOHANDLER* io, cmsUInt32Number* nItems, cmsUInt32Number SizeOfTag)

                                                ^
2 errors generated.

The latter error is easy to workaround. I haven't tried fixing the former.

Thanks,
-Archie

-- 
Archie L. Cobbs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/compiler-dev/attachments/20220929/cf948140/attachment.htm>