RFR: JDK-8312418: Add Elements.getEnumConstantBody [v2]

Vicente Romero vromero at openjdk.org
Wed Aug 23 14:04:23 UTC 2023

On Wed, 23 Aug 2023 09:14:40 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Trivial implementation to get feedback on the proposed API.
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>   Update printing processor.

src/java.compiler/share/classes/javax/lang/model/util/Elements.java line 772:

> 770:      *
> 771:      * @throws IllegalArgumentException if the argument is not an {@code enum} constant
> 772:      * @param enumConstant an enum constant

nice, my only comment is that the order selected in the javadoc seems to be at odds with the rest of the javadoc in this class. The common order I see is:

1. @implSpec
2. @param
3. @return
4. @throws


PR Review Comment: https://git.openjdk.org/jdk/pull/14939#discussion_r1303072140

More information about the compiler-dev mailing list